fix: Crash navigating to notification options - WPB-11062 #2021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When building using iOS 18 SDK on iOS 18 devices there is a crash when navigating to the notifications options screen. This is because we are dequeuing the footer from inside
ConversationNotificationOptionsViewController.collectionView(_:layout:referenceSizeForFooterInSection:)
which we should not be doing.The fix is to create a separate sizing footer view that we only use for generating the reference size.
Testing
This must be tested using an Xcode 16 (iOS 18SDK) build on a iOS 18 device.
Checklist
[WPB-XXX]
.