Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop iOS 15 support - WPB-11374 #2018

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

samwyndham
Copy link
Contributor

@samwyndham samwyndham commented Oct 11, 2024

TaskWPB-11374 Drop support iOS 15

Issue

This PR drops support for iOS 15 setting the minimum deployment target to iOS 16.0.

This has added a number of deprecation warnings to our project. As fixing these will require some effort, I have created linked follow up tickets rather than fixing them in this PR (I did fix one in this PR which was just a rename)

Testing

Run automated tests


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@echoes-hq echoes-hq bot added the echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements label Oct 11, 2024
@samwyndham samwyndham requested review from a team, netbe, agisilaos and KaterinaWire and removed request for a team and agisilaos October 11, 2024 07:17
Copy link
Contributor

github-actions bot commented Oct 11, 2024

Test Results

   12 files    840 suites   11m 37s ⏱️
6 643 tests 6 643 ✅ 0 💤 0 ❌
6 651 runs  6 651 ✅ 0 💤 0 ❌

Results for commit c516479.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added two comments before approving

@samwyndham samwyndham requested a review from netbe October 15, 2024 09:43
@samwyndham samwyndham added this pull request to the merge queue Oct 16, 2024
Merged via the queue into develop with commit 1dd550c Oct 16, 2024
12 checks passed
@samwyndham samwyndham deleted the chore/WPB-11374-drop-iOS-15-support branch October 16, 2024 08:43
@markusfassbender
Copy link
Contributor

Yay 🎉👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants