-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Drop iOS 15 support - WPB-11374 #2018
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: maintenance
Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
label
Oct 11, 2024
samwyndham
requested review from
a team,
netbe,
agisilaos and
KaterinaWire
and removed request for
a team and
agisilaos
October 11, 2024 07:17
samwyndham
commented
Oct 11, 2024
samwyndham
commented
Oct 11, 2024
wire-ios/Wire-iOS/Sources/UserInterface/Location/MapViewController.swift
Show resolved
Hide resolved
samwyndham
commented
Oct 11, 2024
wire-ios/WireCommonComponents/FileMetaDataGenerator/FileMetaDataGenerator.swift
Show resolved
Hide resolved
Test Results 12 files 840 suites 11m 37s ⏱️ Results for commit c516479. ♻️ This comment has been updated with latest results. |
netbe
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just added two comments before approving
wire-ios/WireCommonComponents/FileMetaDataGenerator/FileMetaDataGenerator.swift
Show resolved
Hide resolved
netbe
approved these changes
Oct 15, 2024
KaterinaWire
approved these changes
Oct 15, 2024
Yay 🎉👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: maintenance
Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR drops support for
iOS 15
setting the minimum deployment target toiOS 16.0
.This has added a number of deprecation warnings to our project. As fixing these will require some effort, I have created linked follow up tickets rather than fixing them in this PR (I did fix one in this PR which was just a rename)
Testing
Run automated tests
Checklist
[WPB-XXX]
.