Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: empty state for conversation list - WPB-11341 #2013

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Oct 9, 2024

BugWPB-11341 [iPhone] Empty state for conversation list filter is missing

Issue

Empty states for different filters:
iPhone:

  • all conversations
  • Groups
  • Favorite
  • 1:1

iPad:

  • Groups
  • Favorite
  • 1:1

Note: The Empty placeholder for 1:1 conversations s different for iPhone and iPad.

iPhone design and iPad

Testing

  1. Do not have Favorite conversations and select the filter "Favorites".
  2. Do not have Group conversations and select the filter "Groups".
  3. Do not have 1:1 conversations and select the filter "1:1 conversations".
  4. Do not have any conversations and select the filter "All conversations".

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Test Results

    2 files    293 suites   3m 32s ⏱️
1 808 tests 1 808 ✅ 0 💤 0 ❌
1 816 runs  1 816 ✅ 0 💤 0 ❌

Results for commit 9390960.

♻️ This comment has been updated with latest results.

@KaterinaWire KaterinaWire marked this pull request as ready for review October 14, 2024 06:37
@caldrian caldrian force-pushed the feat/empty-state-for-conversation-list-11341 branch from b444bbd to fa1283b Compare October 16, 2024 11:48
Copy link
Contributor

@caldrian caldrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

@caldrian caldrian merged commit 7df6a1c into epic/navigation-overhaul-WPB-6647 Oct 16, 2024
10 of 11 checks passed
@caldrian caldrian deleted the feat/empty-state-for-conversation-list-11341 branch October 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants