-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: empty state for conversation list - WPB-11341 #2013
Merged
caldrian
merged 28 commits into
epic/navigation-overhaul-WPB-6647
from
feat/empty-state-for-conversation-list-11341
Oct 16, 2024
Merged
feat: empty state for conversation list - WPB-11341 #2013
caldrian
merged 28 commits into
epic/navigation-overhaul-WPB-6647
from
feat/empty-state-for-conversation-list-11341
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: features
End-user visible changes intended to create customer value
label
Oct 9, 2024
Test Results 2 files 293 suites 3m 32s ⏱️ Results for commit 9390960. ♻️ This comment has been updated with latest results. |
caldrian
reviewed
Oct 10, 2024
...onList/ListContent/ConversationListContentController/ConversationListContentController.swift
Outdated
Show resolved
Hide resolved
…e-for-conversation-list-11341
…e-for-conversation-list-11341
…e-for-conversation-list-11341
…e-for-conversation-list-11341
…e-for-conversation-list-11341
…e-for-conversation-list-11341
…e-for-conversation-list-11341
…p/wire-ios into feat/empty-state-for-conversation-list-11341
caldrian
force-pushed
the
feat/empty-state-for-conversation-list-11341
branch
from
October 16, 2024 11:48
b444bbd
to
fa1283b
Compare
caldrian
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work
…e-for-conversation-list-11341
caldrian
merged commit Oct 16, 2024
7df6a1c
into
epic/navigation-overhaul-WPB-6647
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Empty states for different filters:
iPhone:
iPad:
Note: The Empty placeholder for 1:1 conversations s different for iPhone and iPad.
iPhone design and iPad
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: