Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot start conversation - WPB-11454 #2008

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Oct 9, 2024

BugWPB-11454 [iOS] : Users cannot start conversation with users with in Team

Issue

Since supported-protocols were introduced in 3.112.4, we need to know the supported-protocol for the self user and other user for 1-1 conversations. This is either calculated during slowsync or if MLS is enabled during the resolve 1-1 conversations.

There is a bug where supported-protocols are not set for the self user that was logged in before 3.112.4. Indeed if these users update to latest version they don't perform a slowsync (only performed for new client) so they would end up with no supported protocols.

When trying to open a 1-1 conversation in their team, the app would try to resolve the common protocols but endup finding no common protocols and therefore fail with an error.

Solution:

Add a method to calculate the supported-protocols if none exist at the end of the quicksync (so when user put the app on foreground)

Testing

  1. have a build from 3.111.9
  2. login
  3. update to latest build
  4. tap on a new team member to start a 1-1

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: bugs Technical or functional defects in the product label Oct 9, 2024
@netbe netbe changed the title fix: cannort start conversation - WPB-11454 fix: cannot start conversation - WPB-11454 Oct 9, 2024
@netbe netbe changed the title fix: cannot start conversation - WPB-11454 fix: cannot start conversation - WPB-11454 Oct 9, 2024
@netbe netbe marked this pull request as ready for review October 9, 2024 15:15
@netbe netbe requested a review from johnxnguyen October 9, 2024 15:15
@netbe netbe added the release label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Test Results

    4 files    540 suites   11m 1s ⏱️
4 907 tests 4 906 ✅ 0 💤 1 ❌
4 908 runs  4 906 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 6af2ac7.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 9, 2024

Datadog Report

Branch report: fix/WPB-11454-cannort-start-conversation
Commit report: 4ca7c3d
Test service: wire-ios-mono

❌ 1 Failed (0 Known Flaky), 4906 Passed, 0 Skipped, 40.22s Total Time

❌ Failed Tests (1)

  • testThatItWaitsForOneTaskBeforeAnother - UnitTests.DispatchQueueSerialAsyncTests - Details

    Expand for error
     XCTAssertTrue failed
     
     wire-ios-sync-engine/Tests/Source/Utility/DispatchQueueSerialAsyncTests.swift:53
    

@netbe netbe merged commit 82be9e3 into release/cycle-3.113 Oct 10, 2024
10 of 11 checks passed
@netbe netbe deleted the fix/WPB-11454-cannort-start-conversation branch October 10, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: bugs Technical or functional defects in the product release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants