-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cannot start conversation - WPB-11454 #2008
fix: cannot start conversation - WPB-11454 #2008
Conversation
Test Results 4 files 540 suites 11m 1s ⏱️ For more details on these failures, see this check. Results for commit 6af2ac7. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 4906 Passed, 0 Skipped, 40.22s Total Time ❌ Failed Tests (1)
|
Issue
Since supported-protocols were introduced in 3.112.4, we need to know the supported-protocol for the self user and other user for 1-1 conversations. This is either calculated during slowsync or if MLS is enabled during the resolve 1-1 conversations.
There is a bug where supported-protocols are not set for the self user that was logged in before 3.112.4. Indeed if these users update to latest version they don't perform a slowsync (only performed for new client) so they would end up with no supported protocols.
When trying to open a 1-1 conversation in their team, the app would try to resolve the common protocols but endup finding no common protocols and therefore fail with an error.
Solution:
Add a method to calculate the supported-protocols if none exist at the end of the quicksync (so when user put the app on foreground)
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: