Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: navigation into conversations and resolve TODOs - WPB-10141 #2007

Merged
merged 34 commits into from
Oct 9, 2024
Merged

fix: navigation into conversations and resolve TODOs - WPB-10141 #2007

merged 34 commits into from
Oct 9, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 8, 2024 •
edited by github-actions bot
Loading

StoryWPB-10141 [iOS][iPad] Sidebar - Settings&Support

Issue

This PR fixes issues with view controller presentations.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 792132f.

♻️ This comment has been updated with latest results.

@caldrian caldrian force-pushed the fix/settings-subpages-navigation-WPB-10141 branch from bbf20da to d75edf6 Compare October 8, 2024 12:45
@caldrian caldrian changed the title fix: navigation in settings subpages - WPB-10141 fix: navigation in settings subpages and TODOs - WPB-10141 Oct 9, 2024
@caldrian caldrian changed the title fix: navigation in settings subpages and TODOs - WPB-10141 fix: navigation into conversations and resolve TODOs - WPB-10141 Oct 9, 2024
@caldrian caldrian marked this pull request as ready for review October 9, 2024 12:49
@caldrian caldrian merged commit f429131 into epic/navigation-overhaul-WPB-6647 Oct 9, 2024
5 of 11 checks passed
@caldrian caldrian deleted the fix/settings-subpages-navigation-WPB-10141 branch October 9, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caldrian caldrian

Labels
echoes: features End-user visible changes intended to create customer value
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caldrian