Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: process user connection event - WPB-10191 #1994

Merged

Conversation

jullianm
Copy link
Contributor

@jullianm jullianm commented Oct 2, 2024

TaskWPB-10191 [iOS] Process UserConnectionEvent

Key points

This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.

Specifically, this PR is about porting the existing implementation of the UserConnection event.

When we receive an update connection event, the connection is updated locally.
if the connection is accepted, the processors tries to resolve the 1:1 conversation between a self user and another user depending on their common protocol (whether Proteus, MLS or no common protocol).

When the protocol is MLS, the processor tries to establish a new MLS group or join an existing group (depending on the epoch).

Testing

UTs cover the following use cases, ensuring that

  • 1:1 conversation are properly resolved between a self user and another user (MLS, Proteus or no common protocol) by the processor
  • connection is properly updated locally
  • MLS 1:1 conversation is properly fetched from API
  • MLS 1:1 conversation is properly pulled and stored locally.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements echoes/initiative: ios-sync-refactoring labels Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Test Results

2 603 tests   2 603 ✅  7m 0s ⏱️
  276 suites      0 💤
    3 files        0 ❌

Results for commit bb689f8.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@johnxnguyen johnxnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@jullianm jullianm merged commit aa2a698 into refactor/process-user-events Oct 4, 2024
7 of 9 checks passed
@jullianm jullianm deleted the refactor/process-user-connection-event branch October 4, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: ios-sync-refactoring echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants