-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: process user connection event - WPB-10191 #1994
Merged
jullianm
merged 8 commits into
refactor/process-user-events
from
refactor/process-user-connection-event
Oct 4, 2024
Merged
refactor: process user connection event - WPB-10191 #1994
jullianm
merged 8 commits into
refactor/process-user-events
from
refactor/process-user-connection-event
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
echoes: maintenance
Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
echoes/initiative: ios-sync-refactoring
labels
Oct 2, 2024
Test Results2 603 tests 2 603 ✅ 7m 0s ⏱️ Results for commit bb689f8. ♻️ This comment has been updated with latest results. |
jullianm
commented
Oct 2, 2024
...in/Sources/WireDomain/Event Processing/UserEventProcessor/UserConnectionEventProcessor.swift
Outdated
Show resolved
Hide resolved
netbe
approved these changes
Oct 4, 2024
johnxnguyen
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
...in/Sources/WireDomain/Event Processing/UserEventProcessor/UserConnectionEventProcessor.swift
Outdated
Show resolved
Hide resolved
6 tasks
…o OneOnOneResolver, add UTs - WPB-10191 (#1994)
…r-connection-event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes/initiative: ios-sync-refactoring
echoes: maintenance
Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key points
This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.
Specifically, this PR is about porting the existing implementation of the
UserConnection
event.When we receive an update connection event, the connection is updated locally.
if the connection is accepted, the processors tries to resolve the 1:1 conversation between a self user and another user depending on their common protocol (whether Proteus, MLS or no common protocol).
When the protocol is MLS, the processor tries to establish a new MLS group or join an existing group (depending on the epoch).
Testing
UTs cover the following use cases, ensuring that
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: