chore: move WireLogger into WireFoundation - WPB-10941 #1938
+349
−279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: features
caldrian
changed the title
Test Results3 386 tests 3 386 ✅ 6m 12s ⏱️ Results for commit a816f9c. ♻️ This comment has been updated with latest results. |
…-WireLogger-into-WireFoundation-WPB-10941
6 tasks
netbe
reviewed
Oct 7, 2024
| var mergedAttributes: LogAttributes = [:] | ||
| attributes.forEach { |
| @@ -1,19 +1,19 @@ | |||
| { | |||
| "originHash" : "4f1f0d62407d5ee7a355f7111a27d6e49ae5b050e52bf6cdbca00fd5d9be585e", | |||
| "originHash" : "ac941621e4353f6ea1de2917885b39a50d5770cb8bc4e76af0db2004c38b1d41", | |||
| provider.addLogger(logger) | ||
| } | ||
| } | ||
| public typealias WireLogger = WireFoundation.WireLogger |
There was a problem hiding this comment.
that might be confusing, though a good idea to have a default logger here. Does it have to be public?
maybe WireLoggerDefault?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In order to be able to use logging from WireFoundation the Wire Logger must be declared here.
This PR moves all files except WireLoggerObjC to WireFoundation.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: