Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show user image at the conversation list top instead of team image - WPB-11052 #1919

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Sep 12, 2024

StoryWPB-11052 Extract getting the image of the user account use case

Issue

In the iOS app we have been showing the team image at the top of the conversation list.
This PR changes it to the user's image and keeps the team image for the account switcher.

Testing

Log into one or more accounts.
The conversation list should always show the user's image or initials.
Only for switching accounts the team image is visible.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Sep 12, 2024
Copy link
Contributor

Test Results

    2 files    298 suites   5m 27s ⏱️
1 839 tests 1 839 ✅ 0 💤 0 ❌
1 847 runs  1 847 ✅ 0 💤 0 ❌

Results for commit b8e0234.

@caldrian caldrian added this pull request to the merge queue Sep 12, 2024
Merged via the queue into develop with commit 033a5c4 Sep 12, 2024
12 checks passed
@caldrian caldrian deleted the fix/show-user-image-for-team-accounts-WPB-11052 branch September 12, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: features End-user visible changes intended to create customer value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants