-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: process federation delete event - WPB-10188 #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o and add UTs - WPB-10187
…nto refactor/process-federation-delete-event
…nto refactor/process-federation-delete-event
…nto refactor/process-federation-delete-event
Test Results233 tests 233 ✅ 6s ⏱️ Results for commit 18662f1. ♻️ This comment has been updated with latest results. |
netbe
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…nto refactor/process-federation-delete-event
6 tasks
@netbe yep I closed the other PR since changes are already part of this PR |
johnxnguyen
reviewed
Sep 26, 2024
...in/Event Processing/FederationEventProcessor/FederationConnectionRemovedEventProcessor.swift
Outdated
Show resolved
Hide resolved
WireDomain/Sources/WireDomain/Repositories/Connections/ConnectionsLocalStore.swift
Outdated
Show resolved
Hide resolved
johnxnguyen
approved these changes
Oct 4, 2024
….swift Co-authored-by: François Benaiteau <[email protected]>
…eration-delete-event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes/initiative: ios-sync-refactoring
echoes: maintenance
Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Points
This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.
Specifically, this PR is about porting the existing implementation of the
FederationDeleteEventProcessor
event.Legacy code was using a FederationTerminationManager part of WireRequestStrategy framework to manage the storage logic.
To avoid using this internal dependency, we now directly perform the storage logic operations in our dedicated ConnectionRepository object.
Note: The following ongoing PR here was merged into this one as they are closely related.
Testing
UTs cover the following use cases, ensuring that:
pending
connections requests areignored
.sent
connection requests arecancelled
.Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: