Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create sidebar view - WPB-9727 #1916

Merged
merged 111 commits into from
Sep 17, 2024
Merged

chore: create sidebar view - WPB-9727 #1916

merged 111 commits into from
Sep 17, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Sep 11, 2024 •
edited by github-actions bot
Loading

TaskWPB-9727 Implement UISplitViewController for iPad

Issue

This PR creates a sidebar view in a separate WireSidebar target.
It also renames the existing enum AccentColor to WireAccentColor.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian added the WIP label Sep 11, 2024
@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Sep 11, 2024
@caldrian caldrian marked this pull request as ready for review September 11, 2024 11:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Test Results

    4 files    313 suites   2m 43s ⏱️
1 879 tests 1 879 ✅ 0 💤 0 ❌
1 887 runs  1 887 ✅ 0 💤 0 ❌

Results for commit 20e5ebf.

♻️ This comment has been updated with latest results.

@caldrian caldrian changed the base branch from develop to chore/get-account-image-use-case-WPB-11052 September 12, 2024 12:37
@caldrian caldrian marked this pull request as draft September 12, 2024 13:46
@caldrian caldrian force-pushed the feat/create-sidebar-WPB-9727 branch 7 times, most recently from 584ce6f to 1af1e19 Compare September 12, 2024 14:04
Base automatically changed from chore/get-account-image-use-case-WPB-11052 to develop September 16, 2024 17:17
@echoes-hq echoes-hq bot added the echoes: technical-debt Changes intended at mitigating risks label Sep 16, 2024
@samwyndham samwyndham self-requested a review September 17, 2024 08:02
agisilaos
agisilaos reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@agisilaos agisilaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment regarding the name of a test class

WireFoundation/Tests/WireFoundationTests/Utilities/UIImage+fromSolidColorTests.swift Outdated Show resolved Hide resolved
samwyndham
samwyndham approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨

...nceImages/SidebarProfileSwitcherViewSnapshotTests/testDynamicTypeVariants.accessibility5.png Outdated Show resolved Hide resolved
...ts/Resources/ReferenceImages/WireTextStyleMappingTests/testFontDynamicTypeVariants.large.png Outdated Show resolved Hide resolved
...sationList/Container/ConversationListViewController+NavigationBar/AvailabilityMappings.swift Show resolved Hide resolved
WireUI/Sources/WireSidebar/SidebarView.swift Outdated Show resolved Hide resolved
@caldrian caldrian added this pull request to the merge queue Sep 17, 2024
Merged via the queue into develop with commit 78375e1 Sep 17, 2024
13 checks passed
@caldrian caldrian deleted the feat/create-sidebar-WPB-9727 branch September 17, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwyndham samwyndham samwyndham approved these changes

@agisilaos agisilaos agisilaos approved these changes

Assignees

@caldrian caldrian

Labels
echoes: features End-user visible changes intended to create customer value echoes: technical-debt Changes intended at mitigating risks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caldrian @samwyndham @agisilaos