Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation warnings regarding uniform type identifiers - WPB-8778 #1911

Merged
merged 32 commits into from
Sep 13, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Sep 10, 2024

TaskWPB-8778 Clean up code base

Issue

In Swift uniform type identifiers are a dedicated type instead of a string.
Therefore Apple deprecated various API methods and types.

This PR migrates the affected code.

Testing

No changes should be noticed on the user side, especially regarding file previews (pdf, image, video, etc.)


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: technical-debt Changes intended at mitigating risks label Sep 10, 2024
@caldrian caldrian marked this pull request as ready for review September 10, 2024 13:24
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Test Results

    3 files    346 suites   6m 23s ⏱️
2 124 tests 2 124 ✅ 0 💤 0 ❌
2 132 runs  2 132 ✅ 0 💤 0 ❌

Results for commit d2aca89.

♻️ This comment has been updated with latest results.

@wireapp wireapp deleted a comment from datadog-wireapp bot Sep 10, 2024
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just some minor comments)

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I think it would be good to understand the reason for the snapshot test failures before merging though - and ideally removing the snapshot updates. I'm just concerned there is a subtle change we are missing.

@caldrian caldrian changed the base branch from develop to fix/snapshot-reference-images-WPB-8778 September 13, 2024 13:08
@caldrian caldrian force-pushed the fix/snapshot-reference-images-WPB-8778 branch from 081cbc7 to 8d29dcf Compare September 13, 2024 13:39
Base automatically changed from fix/snapshot-reference-images-WPB-8778 to develop September 13, 2024 14:12
@caldrian caldrian added this pull request to the merge queue Sep 13, 2024
Merged via the queue into develop with commit 9ffda96 Sep 13, 2024
12 checks passed
@caldrian caldrian deleted the fix/UTType-deprecations-WPB-8778 branch September 13, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-debt Changes intended at mitigating risks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants