-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecation warnings regarding uniform type identifiers - WPB-8778 #1911
Conversation
…-deprecations-WPB-8778
Test Results 3 files 346 suites 6m 23s ⏱️ Results for commit d2aca89. ♻️ This comment has been updated with latest results. |
…-deprecations-WPB-8778
…-deprecations-WPB-8778
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (just some minor comments)
.../Wire-iOS/Sources/UserInterface/Conversation/InputBar/AudioEffectsPickerViewController.swift
Outdated
Show resolved
Hide resolved
...Wire-iOS/Sources/UserInterface/Settings/Debug Report/SettingsDebugReportViewController.swift
Outdated
Show resolved
Hide resolved
wire-ios/WireCommonComponents/FilePreviewGenerator/MovieFilePreviewGenerator.swift
Outdated
Show resolved
Hide resolved
wire-ios/WireCommonComponents/FilePreviewGenerator/PDFFilePreviewGenerator.swift
Outdated
Show resolved
Hide resolved
...S Tests/ReferenceImages/AuthenticationInterfaceBuilderTests/testActivationScreen_Email.1.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I think it would be good to understand the reason for the snapshot test failures before merging though - and ideally removing the snapshot updates. I'm just concerned there is a subtle change we are missing.
…-deprecations-WPB-8778
081cbc7
to
8d29dcf
Compare
…-deprecations-WPB-8778
Issue
In Swift uniform type identifiers are a dedicated type instead of a string.
Therefore Apple deprecated various API methods and types.
This PR migrates the affected code.
Testing
No changes should be noticed on the user side, especially regarding file previews (pdf, image, video, etc.)
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: