Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build errors in WireDatadog - WPB-10949 #1894

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix: build errors in WireDatadog - WPB-10949 #1894

merged 2 commits into from
Sep 6, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Sep 6, 2024 •
edited by github-actions bot
Loading

BugWPB-10949 Fix Swift compilation settings in packages

Issue

Since WireDatadog hasn't been built during previous CI runs, an error was undetected.
This PR fixes a build error in WireDatadog and updates the workflow definitions in order to build those targets as well.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Sep 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9bc290f.

@echoes-hq echoes-hq bot added echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast and removed echoes: features End-user visible changes intended to create customer value labels Sep 6, 2024
@caldrian caldrian added this pull request to the merge queue Sep 6, 2024
Merged via the queue into develop with commit 1b26641 Sep 6, 2024
12 checks passed
@caldrian caldrian deleted the fix/build-errors-in-wiredatadog-WPB-10949 branch September 6, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe approved these changes

@samwyndham samwyndham samwyndham approved these changes

Assignees

@caldrian caldrian

Labels
echoes: throughput/ci-maintenance Changes we need to do to keep CI healthy and fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caldrian @netbe @samwyndham