Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable Git LFS for WireReusableUIComponents' snapshot reference images - WPB-10959 #1892

Merged
merged 9 commits into from
Sep 11, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Sep 6, 2024

TaskWPB-10959 Enable Git LFS

Issue

The Git repository has grown unnecessarily much by adding and updating snapshot reference images.
This PR enables Git LFS for a subset of images.

Make sure to have git-lfs installed, e.g. by using Homebrew.
See the instructions on https://git-lfs.com.

brew install git-lfs

Afterwards run ./setup.sh again.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Test Results

15 tests   15 ✅  4s ⏱️
 4 suites   0 💤
 1 files     0 ❌

Results for commit 6e6496b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/enable-git-lfs-WPB-10959
Commit report: 565dd2d
Test service: wire-ios-mono

✅ 0 Failed, 10 Passed, 0 Skipped, 1.12s Total Time

@caldrian caldrian force-pushed the chore/enable-git-lfs-WPB-10959 branch from e25660f to 6ab22bd Compare September 6, 2024 11:28
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to be getting Git LFS!

setup.sh Show resolved Hide resolved
@caldrian caldrian added this pull request to the merge queue Sep 11, 2024
Merged via the queue into develop with commit 5c10823 Sep 11, 2024
11 checks passed
@caldrian caldrian deleted the chore/enable-git-lfs-WPB-10959 branch September 11, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: maintenance Maintenance activity - Refactoring , Preventive , Improvements to code , Performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants