-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Failed image message are not visible on chat #WPB-11035 #3516
base: release/candidate
Are you sure you want to change the base?
fix: Failed image message are not visible on chat #WPB-11035 #3516
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3516 +/- ##
=====================================================
+ Coverage 44.85% 44.88% +0.02%
=====================================================
Files 467 467
Lines 15776 15776
Branches 2654 2654
=====================================================
+ Hits 7077 7081 +4
+ Misses 7942 7936 -6
- Partials 757 759 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3516.apk is available for download |
Built wire-android-dev-debug-pr-3516.apk is available for download |
https://wearezeta.atlassian.net/browse/WPB-11035
What's new in this PR?
Issues
When sending image message fails, it was not visible in chat at all, so we have seen on conversation screen that we sent image, but it was not there.
Solutions
While checking for missing image data from remote, we can also check if its our own message, it it is - its safe to display it in chat
Dependencies (Optional)
We also need this change for full experience: wireapp/kalium#3063
Needs releases with:
Testing
How to Test
Attachments (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.