Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show sync retry state for internal build #WPB-11198 #3505

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Oct 15, 2024

StoryWPB-11198 [Android] indicate sync retry state in the app top bar

What's new in this PR?

Issues

Add more debug info in top bar when sync is waiting for the network. This is only available on internal builds.

Solutions

  • add delay to fail message state
  • top bar listens for network observer state

Dependencies (Optional)

Needs releases with:

Testing

How to Test

Disconnect from internet and run the app

Attachments (Optional)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

sonarcloud bot commented Oct 15, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.85%. Comparing base (ffd5445) to head (412bded).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3505      +/-   ##
===========================================
+ Coverage    44.81%   44.85%   +0.03%     
===========================================
  Files          466      467       +1     
  Lines        15766    15778      +12     
  Branches      2654     2654              
===========================================
+ Hits          7066     7077      +11     
- Misses        7939     7944       +5     
+ Partials       761      757       -4     

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd5445...412bded. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3505.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3505.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants