feat: Add call to action button to allow personal users to be able to create a team (WPB-11326) #3497

ohassine · 2024-10-10T14:18:48Z

WPB-11326 [Android] Create Call-To-Action within the app for personal users to be able to start a team

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

In this PR I added:

An indicator in user avatar(home screen) that will be displayed for personal users, to get attention of the user to open profile screen. This indicator will be hidden once the user opens profile screen.
A new info banner in profile screen that will give personal user the ability to create a team

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

… a team

…ion-within-the-app-for-personal-users-to-be-able-to-start-a-team # Conflicts: # kalium

…personal-users-to-be-able-to-start-a-team

ohassine · 2024-10-10T14:24:21Z

⚠️To be merged after 4.9 code freeze

…-app-for-personal-users-to-be-able-to-start-a-team' into Create-Call-To-Action-within-the-app-for-personal-users-to-be-able-to-start-a-team

codecov-commenter · 2024-10-10T15:50:29Z

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 45.31%. Comparing base (004f0c2) to head (e83b84c).

Files with missing lines	Patch %	Lines
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt	40.00%	4 Missing and 2 partials ⚠️
...kotlin/com/wire/android/datastore/UserDataStore.kt	25.00%	3 Missing ⚠️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3497      +/-   ##
===========================================
- Coverage    45.32%   45.31%   -0.01%     
===========================================
  Files          470      470              
  Lines        15692    15710      +18     
  Branches      2626     2629       +3     
===========================================
+ Hits          7112     7119       +7     
- Misses        7836     7844       +8     
- Partials       744      747       +3

Files with missing lines	Coverage Δ
...alling/ongoing/participantsview/ParticipantTile.kt	`0.00% <ø> (ø)`
.../main/kotlin/com/wire/android/ui/home/HomeState.kt	`28.57% <100.00%> (+5.49%)`	⬆️
...id/ui/userprofile/self/SelfUserProfileViewModel.kt	`52.11% <50.00%> (-0.41%)`	⬇️
...kotlin/com/wire/android/datastore/UserDataStore.kt	`30.76% <25.00%> (-0.66%)`	⬇️
...n/kotlin/com/wire/android/ui/home/HomeViewModel.kt	`58.49% <40.00%> (-4.31%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 004f0c2...e83b84c. Read the comment docs.

github-actions · 2024-10-10T16:10:06Z

Built wire-android-staging-compat-pr-3497.apk is available for download

github-actions · 2024-10-10T16:10:14Z

Built wire-android-dev-debug-pr-3497.apk is available for download

github-actions · 2024-10-11T08:55:19Z

Built wire-android-staging-compat-pr-3497.apk is available for download

github-actions · 2024-10-11T08:55:31Z

Built wire-android-dev-debug-pr-3497.apk is available for download

…personal-users-to-be-able-to-start-a-team

sonarcloud · 2024-10-16T13:28:37Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

saleniuk · 2024-10-16T13:41:04Z

app/src/main/kotlin/com/wire/android/ui/common/avatar/UserProfileAvatar.kt

+                    modifier = Modifier
+                        .offset(x = offsetToAlignWithAvatar.dp, y = -offsetToAlignWithAvatar.dp)
+                        .onGloballyPositioned {
+                            userStatusIndicatorParams = it.size.toSize() to it.positionInParent()


It would be better to create separate param for "create team unread" indicator and not use the same as for "user status" because both have slightly different sizes and updating the same param from two different composables can make it so that position of one of them becomes wrong in the end.
If it needs to be in the same place horizontally as "user status" indicator but at the top corner, then I would just remove onGloballyPositioned from this one to not override these params and have them be taken only from "user status" indicator composable.

github-actions · 2024-10-16T14:22:49Z

Built wire-android-staging-compat-pr-3497.apk is available for download

github-actions · 2024-10-16T14:22:58Z

Built wire-android-dev-debug-pr-3497.apk is available for download

ohassine added 2 commits October 10, 2024 16:01

feat: Add Call-To-Action to allow personal users to be able to create…

33978b2

… a team

Merge remote-tracking branch 'origin/develop' into Create-Call-To-Act…

e5a0928

…ion-within-the-app-for-personal-users-to-be-able-to-start-a-team # Conflicts: # kalium

pull-request-size bot added the size/M label Oct 10, 2024

echoes-hq bot added the echoes/initiative: personal-users-to-team-users... label Oct 10, 2024

ohassine requested review from a team, m-zagorski, yamilmedina, vitorhugods, mchenani and saleniuk and removed request for a team October 10, 2024 14:18

github-actions bot assigned ohassine Oct 10, 2024

ohassine added 2 commits October 10, 2024 16:19

chore: cleanup

430d2c9

chore: cleanup

1f75d1c

ohassine added the DO NOT MERGE label Oct 10, 2024

Merge branch 'develop' into Create-Call-To-Action-within-the-app-for-…

a7b1f8f

…personal-users-to-be-able-to-start-a-team

ohassine added 3 commits October 10, 2024 17:05

chore: unit test

15d9afb

Merge remote-tracking branch 'origin/Create-Call-To-Action-within-the…

5773f29

…-app-for-personal-users-to-be-able-to-start-a-team' into Create-Call-To-Action-within-the-app-for-personal-users-to-be-able-to-start-a-team

chore: detekt

6c530ef

feat: support dark mode

a81c2ac

ohassine added DO NOT MERGE and removed DO NOT MERGE labels Oct 16, 2024

ohassine mentioned this pull request Oct 16, 2024

feat: Create team upgrade flow (WPB-11268) #3517

Open

7 tasks

Merge branch 'develop' into Create-Call-To-Action-within-the-app-for-…

e83b84c

…personal-users-to-be-able-to-start-a-team

saleniuk reviewed Oct 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add call to action button to allow personal users to be able to create a team (WPB-11326) #3497

feat: Add call to action button to allow personal users to be able to create a team (WPB-11326) #3497

ohassine commented Oct 10, 2024 •

edited

Loading

ohassine commented Oct 10, 2024

codecov-commenter commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

sonarcloud bot commented Oct 16, 2024

saleniuk Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

feat: Add call to action button to allow personal users to be able to create a team (WPB-11326) #3497

Are you sure you want to change the base?

feat: Add call to action button to allow personal users to be able to create a team (WPB-11326) #3497

Conversation

ohassine commented Oct 10, 2024 • edited Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Description

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

ohassine commented Oct 10, 2024

codecov-commenter commented Oct 10, 2024 • edited Loading

Codecov Report

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

sonarcloud bot commented Oct 16, 2024

Quality Gate passed

saleniuk Oct 16, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Oct 16, 2024

github-actions bot commented Oct 16, 2024

ohassine commented Oct 10, 2024 •

edited

Loading

codecov-commenter commented Oct 10, 2024 •

edited

Loading

saleniuk Oct 16, 2024 •

edited

Loading