Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add-api-v1) Add new resources handling qualified id requests from the backend #WPB-11299 #28

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

spoonman01
Copy link
Contributor

  • Refactor resources and models in specific packages
  • Add /api-version endpoint return version 0 and 1
  • Add DeviceManagementService, shared service between resources, also abstracting database access from api layer
  • Basic integration tests for the new api layer

#WPB-11299

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Current API exposed to the backend did not support qualified ids

Solutions

Add new API version 1 (assumed the previous 1 as v0) in order to support qualified ids being passed from the backend

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Deployed legalhold on staging should have new APIs with the starting path /v1 reacheable


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…m the backend

* Refactor resources and models in specific packages
* Add /api-version endpoint return version 0 and 1
* Add DeviceManagementService, shared service between resources, also abstracting database access from api layer
* Basic integration tests for the new api layer
@spoonman01 spoonman01 self-assigned this Oct 3, 2024
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Oct 3, 2024
* Fix default-domain api running on tests
* Fix merge conflicts
* Remove print lines
* Adjust end lines in resource files
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from my side as we paired on the review

@spoonman01 spoonman01 merged commit 6f622c0 into staging Oct 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants