feat: harden ClientCapabilityDTO for api v7 [WPB-14882] #3151
Conversation
MohamadJaara
changed the title
|
Bencher Report| Branch | feat/harden-ClientCapabilityDTO-for-api-v7 |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 680.62 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 603,656.53 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,344,683.56 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,755.97 |
Datadog ReportBranch report: ✅ 0 Failed, 3278 Passed, 108 Skipped, 1m 2.7s Total Time |
There was a problem hiding this comment.
The tests are failing, and sounds a good idea to have for v8.
The code freeze v7 is more clear now and new types will show up only in v8+
Then we can do the usual new API response support we do. @vitorhugods @MohamadJaara what do you think?
Created a PR in the meantime, with tests for retro compat endpoint.
#3173
…CapabilityDTO-for-api-v7 # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
|
@yamilmedina @vitorhugods i fixed the tests the issue was in how the row json string are generated |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3151 +/- ##
===========================================
+ Coverage 54.13% 54.14% +0.01%
===========================================
Files 1264 1264
Lines 36833 36852 +19
Branches 3738 3738
===========================================
+ Hits 19938 19955 +17
- Misses 15453 15457 +4
+ Partials 1442 1440 -2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
make the ClientCapability accept any unknown values
Causes (Optional)
in the migration from 1pi 6 to 7 there may be a new values there
Solutions
harden the serilizer to accept unknown values
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.