This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
[ci] Make deploys fail if the spec build fails #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our CI deploy action currently asks a server at api.csswg.org to build the spec, and then uses the response to that request as the build output. However, it does not check that the response's HTTP status code is successful, which can result in Internal Server Errors in that server being "propagated" to this spec, rather than resulting in a failed build. Similarly, fatal errors in building the spec (for invalid Bikeshed syntax, for example) would result in the list of errors being deployed. This PR fixes that by allowing `curl` to fail for non-successful HTTP status codes.
|
I opened parallel PRs in wintercg/proposal-minimum-common-api#56, wintercg/runtime-keys#9 and wintercg/proposal-webcrypto-streams#8. See 2d2857c for a test of this change. |
lucacasonato
approved these changes
Aug 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI deploy action currently asks a server at api.csswg.org to build the spec, and then uses the response to that request as the build output. However, it does not check that the response's HTTP status code is successful, which can result in Internal Server Errors in that server being "propagated" to this spec, rather than resulting in a failed build. Similarly, fatal errors in building the spec (for invalid Bikeshed syntax, for example) would result in the list of errors being deployed.
This PR fixes that by allowing
curlto fail for non-successful HTTP status codes.