-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTA-1097 Windup feature parity #872
base: main
Are you sure you want to change the base?
MTA-1097 Windup feature parity #872
Conversation
✅ Deploy Preview for windup-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
See table comparing all XML and YAML files: |
@@ -26,6 +26,9 @@ include::topics/mta-about-home-var.adoc[leveloffset=+3] | |||
// MTA Rules | |||
include::topics/about-rules.adoc[leveloffset=+2] | |||
|
|||
// YAML rule files | |||
// include::topics/yaml-rules.adoc[leveloffset=+3] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked your preview?
==== | ||
.Existing {ProductShortName} rules `.yaml` files | ||
|
||
XML rules are in the process of being replaced with newer YAML rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 RedHat.PassiveVoice 1(32-46) 'being replaced' is passive voice. In general, use active voice. Consult the style guide for acceptable use of passive voice.
|
||
XML rules are in the process of being replaced with newer YAML rules. | ||
|
||
Most of the `.xml` rules files have been converted to comparable `.yaml` rule files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 RedHat.PassiveVoice 3(36-50) 'been converted' is passive voice. In general, use active voice. Consult the style guide for acceptable use of passive voice.
|
||
Most of the `.xml` rules files have been converted to comparable `.yaml` rule files. | ||
|
||
These YAML-based rules are located on GitHub at the following location: link:https://github.com/konveyor/rulesets/tree/main/default/generated[https://github.com/konveyor/rulesets/tree/main/default/generated]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 RedHat.PassiveVoice 5(23-34) 'are located' is passive voice. In general, use active voice. Consult the style guide for acceptable use of passive voice.
|
||
These YAML-based rules are located on GitHub at the following location: link:https://github.com/konveyor/rulesets/tree/main/default/generated[https://github.com/konveyor/rulesets/tree/main/default/generated]. | ||
|
||
The rules are numbered and grouped according to target platform. When you create a new rule, it is helpful to find a rule that is similar to the one you need and use it as a starting template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 RedHat.PassiveVoice 7(10-22) 'are numbered' is passive voice. In general, use active voice. Consult the style guide for acceptable use of passive voice.
|
||
The rules are numbered and grouped according to target platform. When you create a new rule, it is helpful to find a rule that is similar to the one you need and use it as a starting template. | ||
|
||
New YAML rules are continuously added, so it is a good idea to check back frequently to review the updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 RedHat.SimpleWords 9(74-84) Use simple language. Consider using 'often' rather than 'frequently'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you committed your HTML preview to the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing
Reverting commit
This reverts commit 7f746a9.
Jira:
Preview
Features parity table