Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update to frontend 27 09 #4453

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

hcourdent
Copy link
Contributor

@hcourdent hcourdent commented Sep 27, 2024

Important

Added two new changelog entries for 'Custom HTTP routes' and 'Set/Get progress from code' in changelogs.ts.

This description was created by Ellipsis for aaa9012. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to aaa9012 in 14 seconds

More details
  • Looked at 21 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/lib/components/sidebar/changelogs.ts:7
  • Draft comment:
    Consider sorting the changelog entries by date in descending order to ensure the most recent changes are listed first.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is about a change that could improve the code's functionality by making the changelog entries more user-friendly. Sorting by date is a common practice for changelogs to ensure the most recent updates are easily accessible. This is a clear and actionable suggestion that aligns with code quality improvement.
    The comment could be seen as a suggestion rather than a necessary change, as the current order might be intentional for some reason not visible in the diff.
    Even if the current order is intentional, the suggestion to sort by date is a common best practice for changelogs and could be beneficial unless there is a specific reason not to do so.
    The comment is valid and suggests a clear, actionable improvement to the code by sorting changelogs by date. It should be kept.

Workflow ID: wflow_FPvbxoum56hpIEBi


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: aaa9012
Status: ✅  Deploy successful!
Preview URL: https://30050e68.windmill.pages.dev
Branch Preview URL: https://changelog-update-27-09.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit e8e6e23 into main Sep 27, 2024
3 checks passed
@rubenfiszel rubenfiszel deleted the changelog_update_27_09 branch September 27, 2024 19:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants