Skip to content

Commit

Permalink
Typos frontend Instance settings (#4361)
Browse files Browse the repository at this point in the history
  • Loading branch information
hcourdent committed Sep 10, 2024
1 parent 05a6590 commit 516466b
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 21 deletions.
3 changes: 2 additions & 1 deletion frontend/src/lib/components/InstanceSettings.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@
<li>login type usage</li>
<li>workers usage</li>
<li>vcpus usage</li>
<li>memory usage</li>
</ul>
</div>
{#if $enterpriseLicense}
Expand Down Expand Up @@ -381,7 +382,7 @@
<Toggle
options={{
right:
'Require users to have been added manually to windmill to sign in through OAuth'
'Require users to have been added manually to Windmill to sign in through OAuth'
}}
bind:checked={requirePreexistingUserForOauth}
/>
Expand Down
12 changes: 6 additions & 6 deletions frontend/src/lib/components/ObjectStoreConfigSettings.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,14 @@
<input type="text" bind:value={bucket_config.region} />
</label>
<label class="block pb-2">
<span class="text-primary font-semibold text-sm">Access Key ID</span>
<span class="text-primary font-semibold text-sm">Access key ID</span>
<span class="text-tertiary text-2xs"
>If left empty, will be derived automatically from $AWS_ACCESS_KEY_ID, pod or ec2 profile</span
>
<input type="text" bind:value={bucket_config.access_key} />
</label>
<label class="block pb-2">
<span class="text-primary font-semibold text-sm">Secret Key</span>
<span class="text-primary font-semibold text-sm">Secret key</span>
<span class="text-tertiary text-2xs"
>If left empty, will be derived automatically from $AWS_SECRET_KEY, pod or ec2 profile</span
>
Expand All @@ -160,20 +160,20 @@
<div class="block pb-2">
<span class="text-tertiary text-2xs">Disable if using https only policy</span>
<div>
<Toggle bind:checked={bucket_config.allow_http} options={{ right: 'allow http' }} />
<Toggle bind:checked={bucket_config.allow_http} options={{ right: 'Allow http' }} />
</div>
</div>
{:else if bucket_config.type === 'Azure'}
<label class="block pb-2">
<span class="text-primary font-semibold text-sm">Account Name</span>
<span class="text-primary font-semibold text-sm">Account name</span>
<input type="text" placeholder="account-name" bind:value={bucket_config.accountName} />
</label>
<label class="block pb-2">
<span class="text-primary font-semibold text-sm">Container Name</span>
<span class="text-primary font-semibold text-sm">Container name</span>
<input type="text" placeholder="container-name" bind:value={bucket_config.containerName} />
</label>
<label class="block pb-2">
<span class="text-primary font-semibold text-sm">Access Key</span>
<span class="text-primary font-semibold text-sm">Access key</span>
<input type="password" autocomplete="new-password" bind:value={bucket_config.accessKey} />
</label>
<label class="block pb-2">
Expand Down
28 changes: 14 additions & 14 deletions frontend/src/lib/components/instanceSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export type SettingStorage = 'setting' | 'config'
export const settings: Record<string, Setting[]> = {
Core: [
{
label: 'Base Url',
label: 'Base url',
description: 'Public base url of the instance',
key: 'base_url',
fieldType: 'text',
Expand All @@ -54,7 +54,7 @@ export const settings: Record<string, Setting[]> = {
placeholder: 'mail.windmill.com'
},
{
label: 'Request Size Limit In MB',
label: 'Request size limit in MB',
description: 'Maximum size of HTTP requests in MB.',
cloudonly: true,
key: 'request_size_limit_mb',
Expand All @@ -71,16 +71,16 @@ export const settings: Record<string, Setting[]> = {
cloudonly: false
},
{
label: 'Max Timeout for sync endpoints',
label: 'Max timeout for sync endpoints',
key: 'timeout_wait_result',
cloudonly: true,
fieldType: 'seconds',
placeholder: '60',
storage: 'config'
},
{
label: 'License Key',
description: 'License Key required to use the EE (switch image for windmill-ee)',
label: 'License key',
description: 'License key required to use the EE (switch image for windmill-ee)',
key: 'license_key',
fieldType: 'license_key',
placeholder: 'only needed to prepare upgrade to EE',
Expand All @@ -95,7 +95,7 @@ export const settings: Record<string, Setting[]> = {
ee_only: 'This is only relevant for EE'
},
{
label: 'Retention Period in secs',
label: 'Retention period in secs',
key: 'retention_period_secs',
description: 'How long to keep the jobs data in the database (max 30 days on CE)',
fieldType: 'seconds',
Expand All @@ -106,22 +106,22 @@ export const settings: Record<string, Setting[]> = {
},
{
label: 'Expose metrics',
description: 'Expose prometheus metrics for workers and servers on port 8001 at /metrics',
description: 'Expose Prometheus metrics for workers and servers on port 8001 at /metrics',
key: 'expose_metrics',
fieldType: 'boolean',
storage: 'setting',
ee_only: ''
},
{
label: 'S3/Azure for Python/Go Cache & Large Logs',
label: 'S3/Azure for Python/Go cache & large logs',
description: 'Bucket to store large logs and global cache for Python and Go.',
key: 'object_store_cache_config',
fieldType: 'object_store_config',
storage: 'setting',
ee_only: ''
},
{
label: 'Critical Alert Channels',
label: 'Critical alert channels',
description:
'Channels to send critical alerts to. SMTP must be configured for the email channel. A Slack workspace must be connected to the instance for the Slack channel.',
key: 'critical_error_channels',
Expand All @@ -139,8 +139,8 @@ export const settings: Record<string, Setting[]> = {
ee_only: ''
},
{
label: 'Private hub base url',
description: 'Base url of your private hub instance, without trailing slash',
label: 'Private Hub base url',
description: 'Base url of your private Hub instance, without trailing slash',
placeholder: 'https://hub.company.com',
key: 'hub_base_url',
fieldType: 'text',
Expand Down Expand Up @@ -241,7 +241,7 @@ export const settings: Record<string, Setting[]> = {
],
'SCIM/SAML': [
{
label: 'SCIM Token',
label: 'SCIM token',
description: 'Token used to authenticate requests from the IdP',
key: 'scim_token',
fieldType: 'text',
Expand All @@ -261,14 +261,14 @@ export const settings: Record<string, Setting[]> = {
],
Debug: [
{
label: 'Keep Job Directories',
label: 'Keep job directories',
key: 'keep_job_dir',
fieldType: 'boolean',
tooltip: 'Keep Job directories after execution at /tmp/windmill/<worker>/<job_id>',
storage: 'setting'
},
{
label: 'Expose Debug Metrics',
label: 'Expose debug metrics',
key: 'expose_debug_metrics',
fieldType: 'boolean',
tooltip: 'Expose additional metrics (require metrics to be enabled)',
Expand Down

0 comments on commit 516466b

Please sign in to comment.