Directories#1
Merged
willmcgugan merged 5 commits intomasterfrom Jan 21, 2021
Merged
Conversation
toudi
reviewed
Jan 21, 2021
| self.serverurl = None | ||
|
|
||
| self.server_configs = sconfigs = section.server_configs | ||
| self.directories = section.directories |
There was a problem hiding this comment.
so section would be configparser section which defaults to None if not present ?
toudi
reviewed
Jan 21, 2021
toudi
reviewed
Jan 21, 2021
| % (self.name, self.path) | ||
| ) | ||
| else: | ||
| if self.create: |
There was a problem hiding this comment.
shouldn't the syntax support chowning the directory? if the directory is supposed to be created in /tmp then it will suffice but otherwise it may result with a permission error. had this be created by root then the config could also have a syntax for chown'ing the created directory
Owner
Author
There was a problem hiding this comment.
Maybe is should. There was a comment at the end of Supervisor#120 that suggested it didn't need to change the ownership.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds [directory:x] sections. For context see my comment on Supervisor#120