feat: Merge prerelease into master #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: Workday#2238 I've added initial settings for v10 codemod, example codemod has been created to prevent typescript failure in index. [category:Codemods]
Adding the v10 upgrade guide [category:Documentation]
Updating `depth` and `space` tokens to use `rem` rather than `px`. This includes updating components as well since values have been updated to reflect `rem` and not `px` (i.e. `spaceNumbers.s` = `16` and now is `spaceNumbers.s` = `1`. This reflects the new `rem` value.) Fixes: Workday#1227 [category:Components] Release Note: Updated `depth` and `space` token values to use `rem` instead of `px`. ### BREAKING CHANGES There is the possibility of breaking changes if users are changing the default browser font size from `16px` to another value. You can convert a `px` value to a `rem` value by dividing your `px` value by `16`(if your default browser font size hasn't been updated, the value will be `16`). For example: | Equation | rem Value | | ----------- | --------- | | `16px/16px` | `1rem` | | `32px/16px` | `2rem` | | `8px/16px` | `0.5rem` | Co-authored-by: @alanbsmith <[email protected]> Co-authored-by: @bstanton678 <[email protected]> Co-authored-by: @mannycarrera4 <[email protected]>
Removal of the `DeprecatedMenu` and `DeprecatedMenuItem` component in Preview. Fixes: Workday#1993 A compound component version is already in Main. [category:Components] Release Note: This will not involve a codemod since the API has too many differences between the component being removed in Preview and the component in Main. ### BREAKING CHANGES To move from the Menu component in Preview to the Menu compound component in Main, please read [this discussion](Workday#2063). Also, see [this](https://codesandbox.io/s/deprecatedmenu-and-menu-migration-gwi1ov) codesandbox that shows the differences between DeprecatedMenu and the Menu compound component.
Co-authored-by: @willklein <[email protected]> Co-authored-by: @RayRedGoose <[email protected]>
Contributing updates to the accessibility guidelines on the Canvas Kit design site, I noticed the Switch component rendered with an ARIA checkbox role. This didn't seem appropriate for the Switch component. Additionally, removing tabindex attribute. Didn't seem necessary when the input element is already in focus order anyway. [category:Components] Co-authored-by: @alanbsmith <[email protected]>
The useBanner hook is adding the `aria-labelledby` and `aria-describedby` properties to the Banner button element. I removed the call to the hook so the aria attributes are not applied. The Banner button is using `aria-labelledby` referencing the ActionText, and `aria-describedby` referencing the LabelText sub-component. It is difficult to point to measurable "problems" with this, because it does sound nice with screen readers. When `isSticky` prop is used, the ActionText disappears from the screen, while still being referenced as the main label for the button. This will break the experience for Dragon Dictation and Voice Control users because the visible LabelText is not being used as the accessible name of the button element. [category:Components] ### BREAKING CHANGES We have removed the useBanner hook, the only function of which was to add `aria-labelledby` and `aria-describedby` references to the text inside of the Banner. This was not required for accessibility, and browsers can compute the `name` of the Banner from the text given inside. Co-authored-by: @mannycarrera4 <[email protected]> Co-authored-by: manuel.carrera <[email protected]>
Fixes: Workday#2333 [category:Components] Release Note: We're going to continue supporting the Menu in Preview until we implement grouped menu items (with virtualization) for the Menu in Main. Co-authored-by: manuel.carrera <[email protected]>
Fixes: Workday#2186 PR contains `InputIconContainer` deprecation. [category:Components] Release Note: `InputIconContainer` has been deprecated, because it does not handle bidirectionally or icons at the start of an input. Please use [`InputGroup`](https://workday.github.io/canvas-kit/?path=/story/components-inputs-text-input--icons) instead. Co-authored-by: @mannycarrera4 <[email protected]> Co-authored-by: manuel.carrera <[email protected]>
Deprecate `Table` in main. Resolves: Workday#2249 [category:Components] Co-authored-by: @mannycarrera4 <[email protected]>
Co-authored-by: @mannycarrera4 <[email protected]> Co-authored-by: manuel.carrera <[email protected]> Co-authored-by: @jamesfan <[email protected]>
docs: Table with selectable rows example
williamjstanton
changed the title
williamjstanton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: Workday#1234
Release Category
Components
Release Note
Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.
BREAKING CHANGES
Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a
prerelease/majorbranch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)