Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Table with selectable rows example #13

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

williamjstanton
Copy link
Owner

Summary

Fixes: none

Tables with selectable rows have been a "hot topic" within accessibility lately. Specifically, having a checkbox input inside of a columnheader can be confusing when depending on a screen reader. Experimenting with Canvas Tables by using a standard <td> element in the first column header so screen reader do not automatically announce "select all" when reading table cells.

Release Category

Components

Release Note

Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.

BREAKING CHANGES

Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a prerelease/major branch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@williamjstanton williamjstanton changed the title Table with selectable rows example docs: Table with selectable rows example Oct 5, 2023
@williamjstanton williamjstanton changed the base branch from master to prerelease/major October 5, 2023 01:39
@williamjstanton williamjstanton merged commit 6f2506c into prerelease/major Oct 5, 2023
16 of 18 checks passed
@williamjstanton williamjstanton deleted the william-selectable-rows branch November 7, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant