add resilient AnimView fallback and cache bust query param#82
Open
mmsqe wants to merge 2 commits intowill62794:masterfrom
Open
add resilient AnimView fallback and cache bust query param#82mmsqe wants to merge 2 commits intowill62794:masterfrom
mmsqe wants to merge 2 commits intowill62794:masterfrom
Conversation
Owner
|
Can you explain the motivation behind this change more clearly? The bullet points are a bit vague to me. |
Contributor
Author
Sure @will62794, just updated the description, we encountered local specs where AnimView throws during evaluation, adding a fallback plus diagnostics should make debugging easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error evaluating animation view expression: 'AnimView'.to renders a fallback message and logs debug details like nodePos, nodeText, fingerprint./local_dir/*.tla?__ts=...resolves correctly by stripping query params before filesystem mapping in serve.py, while remote spec URLs are unaffected which are fetched directly by browser from remote host.