Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Add prefers-color-scheme variant #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arzafran
Copy link

Fixes #62 :)

}

.tabbrowser-tab[pinned="true"][style^="margin-inline-start"] {
padding-left: 12px !important;
padding-left: 8px !important;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look to be separate from supporting theme-detection. I'll give them a try and see if these numbers work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I've added it to center the icons on pinned tabs:
Screen Shot 2019-11-13 at 16 35 02

Copy link
Owner

@wilfredwee wilfredwee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! Sorry for the late review, life's been busy.

It looks like you're using a formatter. Could you submit either another PR or a change that formats the 2-other files too? This will make future changes easier.

@arzafran
Copy link
Author

arzafran commented Nov 13, 2019

Thanks a lot for the PR! Sorry for the late review, life's been busy.

It looks like you're using a formatter. Could you submit either another PR or a change that formats the 2-other files too? This will make future changes easier.

Just did in the last PR.

btw, don't be sorry! I'm thankful you did all the heavy lifting allowing me to build upon your work a perfect theme for FF 😍

Have a nice week!

@arzafran
Copy link
Author

arzafran commented Nov 13, 2019

just realized that having it to auto detect macOS dark preference having 'dark' and 'light' modes seems redundant..
Maybe it can also make maintenance/documentation/theming easier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default theme does not work in MacOS dark mode
3 participants