Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #121 destruct sigma types #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stchang
Copy link
Collaborator

@stchang stchang commented Jun 17, 2020

This is a temporary fix but it got me thinking, should we disable type checking completely while running tactics? The final term will be type checked anyways right?

@stchang
Copy link
Collaborator Author

stchang commented Jun 17, 2020

fixes #121

@wilbowma
Copy link
Owner

I could see an argument for yes. It would increase performance, and we ought to only be constructing well-typed terms. However, it might also be useful for debugging tactics.

@stchang
Copy link
Collaborator Author

stchang commented Jun 17, 2020

True. I do see that several tactics raise their own exceptions when given an ill-typed expression, so it may not be completely straightforward to completely disable type checking.

For now, I'll just do it when appropriate for individual tactics.

@wilbowma wilbowma changed the base branch from master to main June 18, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants