'NoRep' Einstellung entfernen #1378
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We achieve this by giving single day timeframes an end-date and making the isInTimeframe check for start- and enddate
hansmorb
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
============================================
- Coverage 38.22% 35.88% -2.35%
+ Complexity 2193 2119 -74
============================================
Files 84 83 -1
Lines 8902 8600 -302
============================================
- Hits 3403 3086 -317
- Misses 5499 5514 +15
|
# Conflicts: # src/Plugin.php
# Conflicts: # src/Model/Day.php # src/Service/Upgrade.php # src/Wordpress/CustomPostType/Timeframe.php # tests/php/Model/DayTest.php # tests/php/PluginTest.php # tests/php/Service/UpgradeTest.php # tests/php/View/ViewTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Das entfernt die Funktion "keine Wiederholung" für Zeitrahmen einzustellen und passt vorhandene Zeitrahmen entsprechend an. Dazu wird bei allen Zeitrahmen die 'norep' Einstellung zu 'd' (daily) geändert.
Da Zeitrahmen ohne Wiederholung ohne Enddatum nur für den Tag des Startdatums gültig waren, wird bei diesen Zeitrahmen das Enddatum auf das Startdatum gesetzt.
closes #1005