Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPdoc GBFS api code #1226

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

datengraben
Copy link
Contributor

@datengraben datengraben commented Apr 17, 2023

Im Api Code gab es ein paar deprecations.
Außerdem habe ich fehlende phpdoc-Strings für die Klassen ergänzt.
Jetzt ergibt das hoffentlich ein einheitliches Bild für die REST-API Klassen.

@datengraben datengraben marked this pull request as ready for review September 7, 2023 15:42
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1226 (8edd0bf) into master (8756e2e) will increase coverage by 0.06%.
Report is 39 commits behind head on master.
The diff coverage is 53.92%.

❗ Current head 8edd0bf differs from pull request most recent head 754ed21. Consider uploading reports for the commit 754ed21 to get more accurate results

@@             Coverage Diff              @@
##             master    #1226      +/-   ##
============================================
+ Coverage     34.95%   35.01%   +0.06%     
- Complexity     2115     2118       +3     
============================================
  Files            83       83              
  Lines          8585     8604      +19     
============================================
+ Hits           3001     3013      +12     
- Misses         5584     5591       +7     
Files Coverage Δ
src/API/AvailabilityRoute.php 82.69% <100.00%> (ø)
src/API/GBFS/BaseRoute.php 0.00% <ø> (ø)
src/API/ItemsRoute.php 0.00% <ø> (ø)
src/API/LocationsRoute.php 0.00% <ø> (ø)
src/API/OwnersRoute.php 0.00% <ø> (ø)
src/API/ProjectsRoute.php 0.00% <ø> (ø)
src/API/GBFS/StationInformation.php 0.00% <0.00%> (ø)
src/API/GBFS/StationStatus.php 0.00% <0.00%> (ø)
src/Repository/ApiShares.php 44.44% <66.66%> (ø)
src/API/GBFS/Discovery.php 0.00% <0.00%> (ø)
... and 2 more

src/API/ProjectsRoute.php Outdated Show resolved Hide resolved
@datengraben datengraben merged commit 8abd9e2 into wielebenwir:master Sep 26, 2023
2 checks passed
@datengraben datengraben added the technical Non-functional changes (refactorings or increase test coverage) label Sep 29, 2023
@datengraben datengraben added this to the 2.8.4 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical Non-functional changes (refactorings or increase test coverage)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants