-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHPdoc GBFS api code #1226
Merged
datengraben
merged 8 commits into
wielebenwir:master
from
datengraben:ft-documenting-api-code
Sep 26, 2023
Merged
PHPdoc GBFS api code #1226
datengraben
merged 8 commits into
wielebenwir:master
from
datengraben:ft-documenting-api-code
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1226 +/- ##
============================================
+ Coverage 34.95% 35.01% +0.06%
- Complexity 2115 2118 +3
============================================
Files 83 83
Lines 8585 8604 +19
============================================
+ Hits 3001 3013 +12
- Misses 5584 5591 +7
|
hansmorb
reviewed
Sep 19, 2023
hansmorb
approved these changes
Sep 19, 2023
datengraben
added
the
technical
Non-functional changes (refactorings or increase test coverage)
label
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im Api Code gab es ein paar deprecations.
Außerdem habe ich fehlende phpdoc-Strings für die Klassen ergänzt.
Jetzt ergibt das hoffentlich ein einheitliches Bild für die REST-API Klassen.