This repository has been archived by the owner on Sep 2, 2019. It is now read-only.
Add tests for numerically-based property types #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was noticing that enums seem to fail to load back from Redis. I added some tests to try out some of the base types in DataMapper and found that a few things fail. Perhaps these tests ought to live as a sharable part of dm-core and included here.
|
Hi jof! Thanks for the patch. I did some preliminary work on getting enum types to work at one point for another issue, but I haven't come up with a solution that I really like. Since enum isn't part of the base dm-core install, there needs to be some checking to see if that type is available. I did notice by watching redis monitor that enum keys are stored with a prefix as to which 'type' of enum key it is, so it should be possible to support those types. |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some DataMapper property types that fail to get saved and reconstituted consistently (DateTime, symbolic and textual Enums). So, I added a few tests to show this.
I feel like there are perhaps some properties whose primitive types are not strings already that just need to get cast or something.
Most of the primitives for the failing types are numeric in nature.