Update all examples, and the lt for the type, to the new underscore'd token #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
reviewed
Jul 12, 2025
Comment on lines
+4132
to
+4135
| async_iterable<value_type>; | ||
| async_iterable<value_type>(/* arguments... */); | ||
| async_iterable<key_type, value_type>; | ||
| async_iterable<key_type, value_type>(/* arguments... */); |
There was a problem hiding this comment.
This is not IDL type but the async iterable declaration, which should not change. Multiple people are being confused by this, maybe we should pick some different-enough name for async_iterable?
There was a problem hiding this comment.
Can you explain why the same name here results in a problem for the grammar? Don't we have other concepts that share the name in this way?
There was a problem hiding this comment.
You can try the change and see the linter complain, but basically explained here #1490
| @@ -4211,7 +4211,7 @@ or [=regular operations=] with these names. | |||
| interface SessionManager { | |||
| Session getSessionForUser(DOMString username); | |||
|
|
|||
| async iterable<DOMString, Session>; | |||
| async_iterable<DOMString, Session>; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent commit updated the grammar productions to require
async_iterablerather thanasync iterable, but didn't update the examples in the spec.I also updated the definition text to match.
Preview | Diff