-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cross-origin opener policy concepts #10579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. However, for the impacted <dfn>
elements we should add id
attributes that contain the old (generated) values. That way we are not breaking any links from code, documentation, or elsewhere.
Maybe @domfarolino or @domenic could do a final check on wrapping once that is fixed? Otherwise I'll merge this next week when I have access to a large monitor again. |
bd9ae94
to
ed83182
Compare
I ran |
I'm gonna merge this since Anne said it was good enough to merge modulo wrapping, which I had fixed (#10579 (comment)). |
These two were missed in when whatwg#10579 renamed "cross-origin opener policy" to "opener policy".
These two were missed when whatwg#10579 renamed "cross-origin opener policy" to "opener policy".
These two were missed when whatwg#10579 renamed "cross-origin opener policy" to "opener policy".
These two were missed when #10579 renamed "cross-origin opener policy" to "opener policy".
These two were missed when whatwg#10579 renamed "cross-origin opener policy" to "opener policy".
This is a refactoring-only change, following discussions in #10394
Since this is only an editorial change, there's no need for implementer interest, tests, implementation bugs or MDN changes.
/browsers.html ( diff )
/browsing-the-web.html ( diff )
/document-lifecycle.html ( diff )
/document-sequences.html ( diff )
/dom.html ( diff )
/index.html ( diff )
/browsers.html ( diff )
/browsing-the-web.html ( diff )
/document-lifecycle.html ( diff )
/document-sequences.html ( diff )
/dom.html ( diff )
/index.html ( diff )