Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename cross-origin opener policy concepts #10579

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

yoavweiss
Copy link
Contributor

@yoavweiss yoavweiss commented Aug 27, 2024

This is a refactoring-only change, following discussions in #10394

Since this is only an editorial change, there's no need for implementer interest, tests, implementation bugs or MDN changes.


/browsers.html ( diff )
/browsing-the-web.html ( diff )
/document-lifecycle.html ( diff )
/document-sequences.html ( diff )
/dom.html ( diff )
/index.html ( diff )


/browsers.html ( diff )
/browsing-the-web.html ( diff )
/document-lifecycle.html ( diff )
/document-sequences.html ( diff )
/dom.html ( diff )
/index.html ( diff )

@yoavweiss yoavweiss requested a review from annevk August 27, 2024 12:25
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. However, for the impacted <dfn> elements we should add id attributes that contain the old (generated) values. That way we are not breaking any links from code, documentation, or elsewhere.

@annevk annevk added clarification Standard could be clearer topic: cross-origin-opener-policy Issues and ideas around the new "inverse of rel=noopener" header. labels Sep 2, 2024
source Show resolved Hide resolved
@annevk
Copy link
Member

annevk commented Sep 3, 2024

Maybe @domfarolino or @domenic could do a final check on wrapping once that is fixed? Otherwise I'll merge this next week when I have access to a large monitor again.

@domfarolino
Copy link
Member

domfarolino commented Sep 7, 2024

I ran specfmt on this PR which fixed a bunch of suboptimal wrappings after the renames. I scoured the output and found only one example of domfarolino/specfmt#8 and fixed it manually, so I think this should be good to go.

@domfarolino
Copy link
Member

I'm gonna merge this since Anne said it was good enough to merge modulo wrapping, which I had fixed (#10579 (comment)).

@domfarolino domfarolino merged commit 54acf22 into whatwg:main Sep 12, 2024
2 checks passed
AtkinsSJ added a commit to AtkinsSJ/html that referenced this pull request Sep 18, 2024
These two were missed in when whatwg#10579 renamed "cross-origin opener
policy" to "opener policy".
AtkinsSJ added a commit to AtkinsSJ/html that referenced this pull request Sep 18, 2024
These two were missed when whatwg#10579 renamed "cross-origin opener policy"
to "opener policy".
@AtkinsSJ AtkinsSJ mentioned this pull request Sep 18, 2024
5 tasks
AtkinsSJ added a commit to AtkinsSJ/html that referenced this pull request Sep 18, 2024
These two were missed when whatwg#10579 renamed "cross-origin opener policy"
to "opener policy".
annevk pushed a commit that referenced this pull request Sep 18, 2024
These two were missed when #10579 renamed "cross-origin opener policy" to "opener policy".
dizhang168 pushed a commit to dizhang168/html that referenced this pull request Oct 28, 2024
These two were missed when whatwg#10579 renamed "cross-origin opener policy" to "opener policy".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer topic: cross-origin-opener-policy Issues and ideas around the new "inverse of rel=noopener" header.
Development

Successfully merging this pull request may close these issues.

3 participants