-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Perl preprocessing scripts #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running ./build.sh
, I get this error:
./build.sh: line 648: CARGO_ARGS[@]: unbound variable
I guess it needs to handle the case where |
Oh dear... cannot reproduce. Can you reproduce on main with |
It might be a difference in bash versions. I have bash 5.2.15 in my environment
Yup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
3863ca9
to
d0c6353
Compare
e0c96e3
to
73a4dfc
Compare
73a4dfc
to
d1e0527
Compare
They were replaced by Rust versions in 188742d. Now that the --remote build is available, we should not keep these two code paths around.
Closes #234.
On top of #283 and should not be merged before that is.
Sadly
perl
is still needed forlint.sh
.