feat: 디자인 시스템, 홈바, 카테고리 생성 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaeyeonan
reviewed
Sep 12, 2023
src/components/Homebar.tsx
Outdated
| : mypageOnJuni | ||
| : mypageOff | ||
| }`} | ||
| style={{ width: "36px", height: "36px" }} |
There was a problem hiding this comment.
인라인 스타일은 지양하는게 좋을 것 같아요!
src/styles/Palette.tsx
Outdated
| Sub: "#fdf738", | ||
|
|
||
| White: "#FFFFFF", | ||
| Gray0: "#FFFFFF", |
There was a problem hiding this comment.
혹시 이거 왜 바꾸셨는지 여쭤봐도 될까요??
There was a problem hiding this comment.
피그마에 써져있는 말로 통일하는게 좋을거같아서 바꿨습니다!
There was a problem hiding this comment.
아아 넵 근데 White 가 더 편..하지 않을까요? 하핫
There was a problem hiding this comment.
ㅎㅎ그럼 피그마를 바꾸는걸로 할게요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 관련 이슈
#1
💡 수정 사항