Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] 다짐인증이 몇 번째 인증인지 칼럼을 추가했습니다 #55

Merged
merged 2 commits into from
Dec 21, 2023
Merged

[QA] 다짐인증이 몇 번째 인증인지 칼럼을 추가했습니다 #55

merged 2 commits into from
Dec 21, 2023

Conversation

mkSpace
Copy link
Collaborator

@mkSpace mkSpace commented Dec 21, 2023

QA 사항으로 다짐 인증 전체 조회 시 해당 인증이 몇 번째 인증인지 알려달라고 요청이 와서 이를 반영했습니다

더불어 우선 INTERNAL_ERROR 나는 부분의 Exception의 경우 active-profile이 dev 일 때 stack trace를 그대로 보여주게 변경했습니다!

@mkSpace mkSpace requested a review from K-Diger December 21, 2023 07:57
K-Diger
K-Diger approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@K-Diger K-Diger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요 ^^

@mkSpace mkSpace merged commit a91f423 into develop Dec 21, 2023
2 checks passed
@mkSpace mkSpace deleted the feature/goal-proof-order branch December 21, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Diger K-Diger K-Diger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkSpace @K-Diger