Skip to content

Commit

Permalink
Fix source bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
wgergely committed Sep 12, 2023
1 parent 4e59d20 commit 008728e
Show file tree
Hide file tree
Showing 38 changed files with 3 additions and 2,562 deletions.
6 changes: 1 addition & 5 deletions package/imageutil/include/imageutil.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,9 @@ bool convert_images(const std::vector<std::string>& input_images, const std::vec
/**
* @brief PyBind11 wrapper function for make_thumbnail
*
* @param release_gil The Python GIL won't be hold whilst the function is running when `true` (the default)
*
* The function manages the GIL locking by the extra release_gil parameter
*
* @return `true` on success, `false` on failiure
*/
bool py_convert_image(const std::string& input_image, const std::string& output_image, const int max_size = 512, bool debug = false, bool release_gil = true);
bool py_convert_image(const std::string& input_image, const std::string& output_image, const int max_size = 512, bool debug = false);



Expand Down
9 changes: 2 additions & 7 deletions package/imageutil/src/pyimageutil.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -446,21 +446,17 @@ bool py_convert_image(
const std::string& input_image,
const std::string& output_image,
const int max_size,
bool debug,
bool debug
) {
// GIL is held when called from Python code. Release GIL before
// calling into (potentially long-running) C++ code
return convert_image(input_image, output_image, max_size, debug);
}

bool py_convert_images(
const std::vector<std::string>& input_images,
const std::vector<std::string>& output_images,
const int max_size,
bool debug,
bool debug
) {
// GIL is held when called from Python code. Release GIL before
// calling into (potentially long-running) C++ code
try {
return convert_images(input_images, output_images, max_size, debug);
}
Expand All @@ -481,7 +477,6 @@ PYBIND11_MODULE(pyimageutil, m)
py::arg("max_size") = 512,
py::arg("debug") = false,
py::return_value_policy::copy,
py::call_guard<py::gil_scoped_release>(),
"Create a thumbnail from `input_image` and save it as `output_image`"
);
m.def(
Expand Down
151 changes: 0 additions & 151 deletions package/vcpkg_ports/qt5-base/cmake/configure_qt.cmake

This file was deleted.

101 changes: 0 additions & 101 deletions package/vcpkg_ports/qt5-base/cmake/find_qt_mkspec.cmake

This file was deleted.

Loading

0 comments on commit 008728e

Please sign in to comment.