Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gym mode state persistence riverpod #718

Open
wants to merge 2 commits into
base: feature/flexible-routines
Choose a base branch
from

Conversation

Jackpkn
Copy link

@Jackpkn Jackpkn commented Jan 12, 2025

Description (Proposed Changes)

(Please try to mention in bullet points.)

  • Fixed state modification error in GymMode by properly implementing Riverpod state management pattern
  • Separated state data (GymState) from state logic (GymStateNotifier) following Riverpod best practices
  • Moved state initialization out of widget lifecycle methods to prevent build-time modifications
  • Improved code organization and maintainability

Link to the issue :

(Add link of the issue you have proposed changes to)

  • Link :

Tests

Please make sure to add tests when implementing new features.

Checklist

Please check that the PR fulfills all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • Set a 100 character limit in your editor/IDE to avoid white space diffs in the PR
  • Tests for the changes have been added (for bug fixes / features)
  • Added yourself to AUTHORS.md
  • Updated/added relevant documentation (doc comments with ///).
  • Added relevant reviewers.

…e-persistence-riverpod

- Pull latest changes from the upstream repository.
- Ensure compatibility with the latest upstream updates.
- Resolve conflicts (if any) and align the feature branch with upstream progress.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant