Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select active tab choice as initial choice in ShowTabNavigator #6320

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mgpinf
Copy link
Contributor

@mgpinf mgpinf commented Oct 24, 2024

This introduces the following changes

  • In ShowTabNavigator, select the choice corresponding to the active tab as the initial choice

@mgpinf
Copy link
Contributor Author

mgpinf commented Oct 24, 2024

In my opinion, it would be useful to have active tab choice selected as the initial choice in ShowTabNavigator because if we disable tab bar and use ShowTabNavigator to navigate between tabs, it would indicate the current tab we are on.

This introduces the following changes
- Select the choice corresponding to the active tab as the initial choice
This changes the following
- Update ShowTabNavigator.md with current tab choice documentation
@mgpinf mgpinf force-pushed the select-active-tab-choice branch from 9216673 to 2ee3858 Compare October 31, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant