Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

feat: add custom name mapping Infinity Wallet #490

Closed
wants to merge 4 commits into from

Conversation

InfinityWallet
Copy link

@InfinityWallet InfinityWallet commented Aug 25, 2023

Description

Adds custom name mapping for the Infinity Wallet injected provider.

Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

⚠️ No Changeset found

Latest commit: e6de6e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@InfinityWallet InfinityWallet changed the title Add Infinity Wallet feat: add custom name mapping Infinity Wallet Aug 25, 2023
Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changeset with pnpm changeset and alphabetize in a few places.

@@ -9,6 +9,7 @@ import {
import { ConnectorData } from './base'

type InjectedProviderFlags = {
isInfinityWallet?: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetize

@@ -5,6 +5,7 @@ import { getInjectedName } from './getInjectedName'

describe.each([
{ ethereum: undefined, expected: 'Injected' },
{ ethereum: { isInfinityWallet: true }, expected: 'Infinity Wallet' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetize

@@ -4,6 +4,7 @@ export function getInjectedName(ethereum?: WindowProvider) {
if (!ethereum) return 'Injected'

const getName = (provider: WindowProvider) => {
if (provider.isInfinityWallet) return 'Infinity Wallet'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alphabetize

@tmm
Copy link
Member

tmm commented Aug 31, 2023

Was unable to push updates. Feel free to re-open this PR with PR feedback added or enable pushes.

@tmm tmm closed this Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants