This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
Fix/make wc connector more caip compliant #401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix optionalNamespaces returning invalid empty []
Better CAIP compliance
Up until now WalletConnectConnector was set up to handle namespaces that included all data under global
eip155
key i.e.This worked as that's how majority of wallets implement the spec, however with v1 sunset we saw few wallets that return namespaces in another format (also valid)
Plus, there can be a combination of both formats returned. I updated connector to handle both when checking namespace chainId's and methods for validation.
Additional Information
Your ENS/address: asimetriq.eth