Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Add BRNKC Mainnet and BRNKC Testnet #300

Merged
merged 17 commits into from
May 23, 2023
Merged

Add BRNKC Mainnet and BRNKC Testnet #300

merged 17 commits into from
May 23, 2023

Conversation

BearNetwork-BRNKC
Copy link
Contributor

Description

Concise description of proposed changes

Additional Information

Your ENS/address:

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2023

🦋 Changeset detected

Latest commit: 776cdf4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wagmi/chains Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/eleven-trainers-yell.md Outdated Show resolved Hide resolved
.changeset/eleven-trainers-yell.md Outdated Show resolved Hide resolved
blockExplorers: {
default: {
name: 'BrnkTestScan',
url: 'https://brnktest-scan.bearnetwork.net/',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: 'https://brnktest-scan.bearnetwork.net/',
url: 'https://brnktest-scan.bearnetwork.net',

@BearNetwork-BRNKC
Copy link
Contributor Author

@tmm Thank you very much. We have confirmed the changes.

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also want to export the chains from the index.ts file.

'@wagmi/chains': patch
---

Added Bear Network Mainnet and Testnet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Added Bear Network Mainnet and Testnet
Added Bear Network Mainnet and Testnet

Comment on lines 101 to 102
export { brnkc } from './BearNetworkChainMainnet'
export { brnkcTestnet } from './BearNetworkChainTestnet'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please alphabetize

Comment on lines 101 to 102
export { BearNetworkChainMainnet } from './BearNetworkChainMainnet'
export { BearNetworkChainTestnet } from './BearNetworkChainTestnet'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please alphabetize. Also, missed this earlier: the chain names and file names should be lower camelcase (e.g. bearNetworkChainMainnet)

@BearNetwork-BRNKC
Copy link
Contributor Author

@tmm Wow, Thank you very much for your guidance.

@BearNetwork-BRNKC
Copy link
Contributor Author

@tmm Wow, I'm thrilled that it's done. I sincerely appreciate your guidance.

@BearNetwork-BRNKC
Copy link
Contributor Author

@tmm That's fantastic! I greatly appreciate your assistance.

Comment on lines 16 to 17
export { bearNetworkChainMainnet } from './bearNetworkChainMainnet'
export { bearNetworkChainTestnet } from './bearNetworkChainTestnet'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be below baseGoerli to be alphabetized

@BearNetwork-BRNKC
Copy link
Contributor Author

@tmm I deeply appreciate your immense kindness and generosity. Thank you very much.

@BearNetwork-BRNKC
Copy link
Contributor Author

@tmm I sincerely apologize for taking up so much of your valuable time. I am truly sorry for the inconvenience caused.

At the same time, I want to express my heartfelt gratitude for your willingness to spend time correcting our mistakes and successfully completing a series of adjustments.

You are truly a kind-hearted person.

@BearNetwork-BRNKC
Copy link
Contributor Author

@tmm
May I ask if there are any other instructions or actions we need to take, such as clicking on something or making any modifications?

@tmm tmm merged commit 577d2a0 into wevm:main May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants