Add auth package #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikelsr I think I'm finally starting to pick up speed. Marking as draft until I get passing tests. Expect PRs relating to CI. Would love to get your early feedback :) |
mikelsr
reviewed
Sep 16, 2024
| "github.com/libp2p/go-libp2p/core/crypto" | ||
| ) | ||
|
|
||
| var _ Policy = (*Terminal_login_Results)(nil) |
There was a problem hiding this comment.
What is the unamed variable used for?
| // with name "libp2p-peer-record". | ||
| var AuthDomain_PayloadType = []byte{0xbb, 0xbb} // TODO: pick better numbers | ||
|
|
||
| var _ record.Record = (*expect)(nil) |
There was a problem hiding this comment.
I see the global unamed variable pattern in more than one file, what is it for? 👀
ww_test.go
Outdated
There was a problem hiding this comment.
Would it make sense to remove the file?
…65715-46ccd63a72af to fix e-order violation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. I'm setting up the backbone for our auth system. Objective is to have a login message flow, that applies a trivial policy (allow all).
At a high level, auth works by bundling the guest process'
(stdout, stdin)into something called a "socket", and exporting aTerminalclient over a Cap'n Proto RPC connection. The present PR stops short of this full implementation, and only provides theauthpackage.Follow-up work: