-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data / ib - fetch futures data #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran accros this randomly and just wanted to let you know that a fork I made of the great Quantopian prject has support for different market hours for futures: https://github.com/rsheftel/pandas_market_calendars |
@rsheftel score. I was thinking I couldn't be the only one who might need something like https://pandas-market-calendars.readthedocs.io/en/latest/calendars.html. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the IB data fetcher class only pulls in stock data.
Let's add another method (keeping it somewhat uniform so we have a solid data fetcher interface for other data feeds) for futures data.
A couple things to keep in mind,
the calendar that calculates RTH will be different since we'll fetching data from a different exchange
not all US futures have the same RTH. Eg, /MES and /ZC and /M6E have different market hours. If possible, let's have the
rth
field account for this. This is not possible based on the current support fromtrading_calendars
, see CME calendar - products have different open/close ranges quantopian/trading_calendars#139.Is there any easy way to test this?