Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping text around an image #40

Open
wants to merge 7 commits into
base: f/modal-draggable
Choose a base branch
from
Open

Wrapping text around an image #40

wants to merge 7 commits into from

Conversation

bishoymelek
Copy link
Contributor

@bishoymelek bishoymelek commented Dec 12, 2021 •
edited

@bishoymelek bishoymelek self-assigned this Dec 12, 2021
@bishoymelek bishoymelek changed the title added design plugins Wrapping text around an image Dec 20, 2021
@bishoymelek bishoymelek marked this pull request as ready for review December 20, 2021 11:23
penk85
penk85 approved these changes Dec 20, 2021
View reviewed changes
Copy link

@penk85 penk85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 👍

roosnic1
roosnic1 suggested changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@roosnic1 roosnic1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not ready yet. The UX behavior is very unclear and need some defining first. Let's but this on hold and check again after the v1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roosnic1 roosnic1 roosnic1 requested changes

@penk85 penk85 penk85 approved these changes

@camilleory camilleory camilleory approved these changes

@tomaszdurka tomaszdurka Awaiting requested review from tomaszdurka

Assignees

@bishoymelek bishoymelek

Labels
PR: New Feature ❤️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bishoymelek @roosnic1 @penk85 @camilleory