GH-264: Implement upsert/delete #283
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nigel Liang <[email protected]>
Also fixes a bug in the schema retriever logic where key schemas were not being reported to schema retrievers.
|
Whoops--meant to open this against our own fork! Was planning on opening a PR against this one once everything had passed internal code review and was in ready-to-merge state--will reopen once that happens. |
C0urante
changed the title
C0urante
changed the title
C0urante
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements upsert/delete roughly as described in #264 and the collaborative design doc.
Adds integration tests for upsert/delete and fixes a small bug in the connector's
SchemaRetrieverAPI. For instructions on running the tests, see the changes to theREADME.The tests cover:
MemorySchemaRetriever), and correctness-of-content verification for all three.There's also an ignored-by-default throughput test that generates 1,000,000 records into Kafka, runs the connector in upsert-delete mode, and outputs the time taken between starting the connector and commit of offsets for every record produced.