feat: sign prescriptions using encrypted private key #19
+239
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroenrinzema
force-pushed
the
feat/sign-prescriptions
branch
from
e681983 to
4eb3d54
Compare
| } | ||
|
|
||
| async function signPrescription(prescription: string): Promise<Signature> { | ||
| if (!wrapperKey && !privateKey) { |
There was a problem hiding this comment.
Do we need to check that privateKey is not provided? What happens if we get private key and no wrapper key? should we handle that?
There was a problem hiding this comment.
Will add a check for this case but an error should be thrown.
| @@ -96,7 +98,7 @@ | |||
| pharmacy = (await getPharmacy(patientId, selectedDrugId)) ?? null; | |||
| if (!pharmacy) { | |||
| pharmacyError = | |||
| "We were unable to find a mail order pharmacy for the given patient and selected medication"; | |||
| "We were unable to find a mail order pharmacy for the gscriptatient and selected medication"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the ability to decode private keys passed by the client