Revert to pa11y 5.1.0 as there's flaky dependencies issue with 6 #10484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 854 kB ℹ️ View Unchanged
|
gestchild
approved these changes
Dec 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is this for?
Devs
What is it doing for them?
I'd moved to the latest version of pa11y (
6.2.3) as it tested against WCAG 2.1, but it caused issues in Docker with the dependencies. I tried a fix; updating the packages was a good thing, but there was still an issue with Puppeteer and installing Chromium.It looks like they'll be updating their dependencies (crucially, puppeteer, which currently runs on v9 but exists up to v21). I've subscribed to that ticket and their
7.0.0ticket as well and we can see when it gets released if that fixes our issues.In the meantime, I'm reverting to the version we had before.