Remove the ResultType datatype
#1354
Open
+51
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result, we lose some information when translating to `Hs`, but we don't really need this special datatype anyway. The upside is that it makes the definitions of foreign import declarations more uniform. This will help me with resolving #1282.
In short: `null xs /= null (catMaybes xs)`, but we were using the former as a conditional to decide how to render the output, while we should have been using the latter conditional.
jorisdral
force-pushed
the
jdral/remove-result-type
branch
from
2844fce to
dac9ae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preparation for issue #1282.
See the commit messages