Structured representation for Eval #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverages DAP feature of returning structured variable reference rather than the evaluation string when the evaluate request is for a single variable. This is useful in the Watch context and for interactive exploration in the REPL, besides the variables pane. `show <var>` or `print <var>` can be used to reproduce the old behavior of printing the variable value whole. Fixes #116 Fixes #108
In the previous commit we used a contrived approach to returning a structured representation for only variables which were evaluated. However, we can go further and (even more easily/uniformly!) display all evaluated expressions in their structured form. The unstructured form can still be gotten by `show` or `print` (In fact, all expressions evaluated end up being `print`ed to stdout so you see them currently, besides the structured representation, even without manually printing them). Fixes #116 BETTER
alt-romes
force-pushed
the
wip/romes/116
branch
from
0c18c38 to
da4bdf4
Compare
alt-romes
force-pushed
the
wip/romes/116
branch
from
da4bdf4 to
daec677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116
Fixes #108